4. add bundle repo validator #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ 86 passed ⋅ (learn more) |
dfrankland
commented
Oct 2, 2024
|
|
||
| fn safe_truncate_string<'a, const MAX_LEN: usize, T: AsRef<str>>(value: &'a T) -> &'a str { | ||
| safe_truncate_str::<MAX_LEN>(value.as_ref()) | ||
| } | ||
|
|
||
| fn safe_truncate_str<'a, const MAX_LEN: usize>(value: &'a str) -> &'a str { | ||
| &value.trim()[..value.floor_char_boundary(MAX_LEN)] | ||
| } | ||
|
|
||
| #[derive(Debug, Clone)] | ||
| enum FieldLen { | ||
| TooShort(String), | ||
| TooLong(String), | ||
| Valid, | ||
| } | ||
|
|
||
| fn validate_field_len<const MAX_LEN: usize, T: AsRef<str>>(field: T) -> FieldLen { | ||
| let trimmed_field = field.as_ref().trim(); | ||
| let trimmed_field_len = trimmed_field.len(); | ||
|
|
||
| if trimmed_field_len == 0 { | ||
| FieldLen::TooShort(String::from(trimmed_field)) | ||
| } else if (1..=MAX_LEN).contains(&trimmed_field_len) { | ||
| FieldLen::Valid | ||
| } else { | ||
| FieldLen::TooLong(String::from(safe_truncate_string::<MAX_LEN, _>( | ||
| &trimmed_field, | ||
| ))) | ||
| } | ||
| } | ||
| mod string_safety; |
There was a problem hiding this comment.
Moved this to its own module for better organization
context/src/repo/validator.rs
Outdated
There was a problem hiding this comment.
Currently we don't validate this data we collect independently from other pieces of context like env. This helps to check independently whether we have this information before we mash everything together.
context/src/string_safety.rs
Outdated
There was a problem hiding this comment.
moved from lib.rs for organization
dfrankland
force-pushed
the
dylan/split-api-test-utils-and-bundlrepo-from-cli
branch
from
7924e52 to
c72e8f9
Compare
dfrankland
force-pushed
the
dylan/bundle-repo-validator
branch
from
93bc18f to
ee13d21
Compare
dfrankland
force-pushed
the
dylan/split-api-test-utils-and-bundlrepo-from-cli
branch
from
c72e8f9 to
a1702f1
Compare
dfrankland
force-pushed
the
dylan/bundle-repo-validator
branch
from
ee13d21 to
68e72f4
Compare
gnalh
approved these changes
Oct 2, 2024
Base automatically changed from
dylan/split-api-test-utils-and-bundlrepo-from-cli
to
main
October 3, 2024 15:18
dfrankland
force-pushed
the
dylan/bundle-repo-validator
branch
from
68e72f4 to
6e04e29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #109
Adds validation for git repo details we collect independently from other context we collect