add CI build and test for context-py #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ 91 passed ⋅ (learn more) |
dfrankland
requested review from
TylerJang27,
gnalh,
tenesttang-trunk and
max-trunk
gnalh
approved these changes
Oct 4, 2024
Comment on lines
+46
to
+51
| if [ -f /usr/bin/dnf ]; then | ||
| # quay.io/pypa/manylinux_2_28_x86_64:latest | ||
| /usr/bin/dnf upgrade | ||
| /usr/bin/dnf install -y pkgconf perl-IPC-Cmd openssl-devel python3-pip | ||
| /usr/bin/ln -s /usr/bin/pip3 /usr/bin/pip | ||
| /usr/bin/ln -sf /usr/bin/python3.11 /usr/bin/python3 |
There was a problem hiding this comment.
# Needed for `openssl-sys`:
# https://docs.rs/openssl/latest/openssl/
dfrankland
commented
Oct 4, 2024
There was a problem hiding this comment.
This file is not used by trunk CLI (and IMO is very divergent from normal Rust code styling)
Comment on lines
+1
to
+2
| [bandit] | ||
| exclude = tests |
There was a problem hiding this comment.
asserts are used in tests and bandit says to exclude tests 🤷
https://bandit.readthedocs.io/en/latest/config.html#exclusions
There was a problem hiding this comment.
upgraded to support python linters and formatters
Comment on lines
-33
to
42
| disabled: | ||
| enabled: | ||
| - trunk-announce | ||
| - trunk-check-pre-push | ||
| - trunk-fmt-pre-commit | ||
| enabled: | ||
| - trunk-upgrade-available |
There was a problem hiding this comment.
I think we want to use these
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a build and test process for
context-pyPython bindings