add test for api_client slow API call logging #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfrankland
force-pushed
the
dylan/add-api-client-slow-api-call-logging-tests
branch
from
415b757 to
7dc5d35
Compare
|
390 tests were run on |
dfrankland
commented
Oct 11, 2024
test_utils/src/mock_server.rs
Outdated
Comment on lines
39
to
58
| #[derive(Debug, Clone)] | ||
| pub struct MockServerBuilder { | ||
| repo_create_handler: MethodRouter<SharedMockServerState>, | ||
| create_bundle_handler: MethodRouter<SharedMockServerState>, | ||
| get_quarantining_config_handler: MethodRouter<SharedMockServerState>, | ||
| s3_upload_handler: MethodRouter<SharedMockServerState>, | ||
| } | ||
|
|
||
| impl MockServerBuilder { | ||
| pub fn new() -> Self { | ||
| Self { | ||
| repo_create_handler: post(repo_create_handler), | ||
| create_bundle_handler: post(create_bundle_handler), | ||
| get_quarantining_config_handler: post(get_quarantining_config_handler), | ||
| s3_upload_handler: put(s3_upload_handler), | ||
| } | ||
| } |
There was a problem hiding this comment.
allows setting the route handlers for doing things like failed API calls, slow API calls, etc.
Comment on lines
+255
to
+299
| let mut mock_server_builder = MockServerBuilder::new(); | ||
| let logs = mock_logger(None); | ||
| let (events, guard) = mock_sentry(); | ||
|
|
||
| async fn slow_s3_upload_handler() -> Response<String> { | ||
| time::sleep(Duration::from_secs(11)).await; | ||
| Response::new(String::from("OK")) | ||
| } | ||
| mock_server_builder.set_s3_upload_handler(slow_s3_upload_handler); |
There was a problem hiding this comment.
Now we have some really awesome ability to capture logs, Sentry events, and modify APIs for tests
gnalh
approved these changes
Oct 15, 2024
dfrankland
force-pushed
the
dylan/add-api-client
branch
from
27166f5 to
c9483e5
Compare
dfrankland
force-pushed
the
dylan/add-api-client-slow-api-call-logging-tests
branch
from
b3b7442 to
52d9a2a
Compare
dfrankland
force-pushed
the
dylan/add-api-client-slow-api-call-logging-tests
branch
from
52d9a2a to
ed683ea
Compare
dfrankland
deleted the
dylan/add-api-client-slow-api-call-logging-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #118
Adds more testing for the
ApiClient, plus the logging and reporting it performs