Build wasm package #133
Merged
Build wasm package #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
406 tests were run on |
dfrankland
force-pushed
the
dylan/wasm-build
branch
from
a30e864 to
15ccc7e
Compare
dfrankland
commented
Oct 26, 2024
Comment on lines
-40
to
42
| pub fn env_validate(ci_info: env::parser::CIInfo) -> env::validator::EnvValidation { | ||
| env::validator::validate(&ci_info) | ||
| pub fn env_validate(ci_info: &env::parser::CIInfo) -> env::validator::EnvValidation { | ||
| env::validator::validate(ci_info) | ||
| } |
There was a problem hiding this comment.
Turns out that only references work as arguments for wasm-exported functions
Comment on lines
+189
to
+193
| #[cfg(feature = "wasm")] | ||
| #[wasm_bindgen] | ||
| impl BundleRepo { | ||
| #[wasm_bindgen(constructor)] | ||
| pub fn js_new( |
There was a problem hiding this comment.
These constructors are needed to use new in JS
dfrankland
force-pushed
the
dylan/wasm-build
branch
from
45a8100 to
e8e601d
Compare
TylerJang27
approved these changes
Oct 28, 2024
Comment on lines
+106
to
+108
| - name: Setup and build wasm | ||
| uses: ./.github/actions/setup_build_wasm | ||
|
|
There was a problem hiding this comment.
Sanity check: is the intention here to build the wasm targets and then run eslint on them in CI? Is there a specific pattern/issue that this is designed to catch (other than just making sure they build as part of a PR workflow)?
There was a problem hiding this comment.
I'm running lints that take into account types on the test code. The test code relies on types from the wasm build, so I have to build the wasm package prior to linting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #135