Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix passing false flags which default true #200

Merged
merged 1 commit into from
Dec 6, 2024
Merged

fix passing false flags which default true #200

merged 1 commit into from
Dec 6, 2024

Conversation

dfrankland
Copy link
Member

@dfrankland dfrankland commented Dec 6, 2024 •
edited
Loading

My bad, I made a change with a bad test 😢

@dfrankland dfrankland requested a review from max-trunk December 6, 2024 18:33
max-trunk
max-trunk approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@max-trunk max-trunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 👍

@dfrankland dfrankland merged commit be04435 into main Dec 6, 2024
13 checks passed
@trunk-staging-io Trunk-Staging.io
Copy link

trunk-staging-io bot commented Dec 6, 2024 •
edited
Loading

Static Badge   Static Badge   Static Badge   Static Badge

View Full Report ↗︎ ⋅ Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@max-trunk max-trunk max-trunk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dfrankland @max-trunk