fix setting default-true flags to false #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfrankland
force-pushed
the
dylan/fix-setting-default-true-flags-to-false
branch
from
788a7f6 to
f3b3fc2
Compare
max-trunk
approved these changes
Dec 9, 2024
dfrankland
commented
Dec 9, 2024
| @@ -99,6 +100,7 @@ pub struct UploadArgs { | |||
| help = "Do not fail if test results are not found.", | |||
| action = ArgAction::Set, | |||
| required = false, | |||
| require_equals = true, | |||
There was a problem hiding this comment.
without these, argument parsing fails, and consequently the above test fails
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
more thorough testing