Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if cli exists before executing #237

Closed
wants to merge 1 commit into from
Closed

Conversation

pat-trunk-io
Copy link
Contributor

@pat-trunk-io pat-trunk-io commented Dec 14, 2024

Check if CLI exists before executing.

We have seen some sporadic exit code 127.

https://trunk-io.slack.com/archives/C044VBASZ0D/p1734148787307919?thread_ts=1734148787.307919&cid=C044VBASZ0D

Signed-off-by: pat-trunk-io <pat@trunk.io>
Copy link

trunk-io bot commented Dec 14, 2024

🚫 This pull request was closed by @pat-trunk-io, so it was removed from the merge queue. See more details here.

@pat-trunk-io pat-trunk-io requested a review from gnalh December 14, 2024 16:58
Copy link

trunk-staging-io bot commented Dec 14, 2024

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

Copy link
Collaborator

@gnalh gnalh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is what we should do here since it obfuscates the results. I worry we'll see green and assume we're good to release.

@pat-trunk-io
Copy link
Contributor Author

I mean then it's a bit of a Heisenberg bug. If we observe it we can't reproduce, but if we don't observe it will happen.

Fwiw, what I'm trying to figure is "what" is missing here. Exit code 127 means an executable was missing, but is it the analytic cli or something that it calls?

@gnalh
Copy link
Collaborator

gnalh commented Dec 14, 2024

The failure happened when running nextest. It doesn't seem to be a missing cli.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants