[TRUNK-13813] Smoke test PRs

[cmillar-trunk]

Adds the smoke test to prs. Does not notify slack to avoid noise.

[trunk-io]

😎 Merged successfully - details.

[pat-trunk-io]

Do we want to run on latest build or the currently latest in the github action. I could see value for both but I think we definitely at least want the latter

[cmillar-trunk]

Since this is triggered on prs, I want it running on the pr branch. Unless I've horribly misunderstood workflows, using the checkout with ref: ${{ github.base_ref }} should be putting us there, right?

[pat-trunk-io]

Maybe this needs to be a separate test then, but I would really like to test staging services against what is latest in the GH action

[dfrankland]

Yep, agreed. We want testing of main and we want testing of a "pinned" version for both staging and prod.

Additionally, I don't mind a PR smoke test, but I don't think it's as needed right now as the above.

[cmillar-trunk]

Ah, gotcha. I'll pivot this to do that instead and post to channel.

[dfrankland]

If most of these steps are shared across smoke test workflows, let's make an action to keep things DRY

analytics-cli/.github/workflows/smoke_test.yml

Lines 24 to 46 in 9fbb8d4

	- name: Setup Rust & Cargo
	uses: ./.github/actions/setup_rust_cargo
	- name: Install Nextest
	shell: bash
	run: |
	cargo install --version 0.9.85 cargo-nextest
	- name: Install cmake
	shell: bash
	run: |
	sudo apt-get install cmake -y
	- name: Run succeeding test
	env:
	TRUNK_PUBLIC_API_ADDRESS: https://api.trunk-staging.io
	shell: bash
	run: |
	./trunk-analytics-cli test \
	--org-url-slug trunk-staging-org \
	--junit-paths ${{ github.workspace }}/target/**/*junit.xml \
	--token ${{ secrets.TRUNK_STAGING_ORG_API_TOKEN }} \
	cargo nextest run -p smoke-test --profile ci

[cmillar-trunk]

Good point; refactored

[trunk-staging-io]

     

View Full Report ↗︎ ⋅ Docs

[dfrankland]

Looks good