Track cli version #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zaycev
reviewed
Jul 9, 2024
| @@ -206,12 +206,7 @@ async fn run_upload( | |||
| }); | |||
| let meta = BundleMeta { | |||
| version: META_VERSION.to_string(), | |||
| cli_version: format!( | |||
There was a problem hiding this comment.
should we just split this into 3 fields? Why do we have to do this in first place?
There was a problem hiding this comment.
Not sure why we had this in the first place, we don't use any of the other fields in the ETL it seems (we weren't even using cli_version). I think we log all 3 fields when running the CLI so might've just copied over that string
|
We will instead extract the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://linear.app/trunk/issue/TRUNK-11730/track-analytics-cli-version-in-upload