Update BundleUpload status for observability #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-fff
force-pushed
the
pr99
branch
3 times, most recently
from
65d855d to
19c41c6
Compare
dfrankland
reviewed
Sep 20, 2024
matt-fff
force-pushed
the
pr99
branch
3 times, most recently
from
a21bdd1 to
a69301f
Compare
Summary: This change will help us give users visibility during onboarding. We can tell them how many uploads calls we've received and how many of them were successful. This will hopefully translate into less time users have to spend waiting to get value from flaky tests. Closes TRUNK-12756 Test Plan: TODO
|
✅ 75 passed ⋅ (learn more) |
dfrankland
approved these changes
Sep 23, 2024
|
@dfrankland mind giving this a quick re-review? Since your last approval - resolved some merge conflicts, fixed a bad enum value, and refactored the API call in |
max-trunk
requested review from
dfrankland,
TylerJang27 and
tenesttang-trunk
dfrankland
approved these changes
Oct 2, 2024
tenesttang-trunk
approved these changes
Oct 2, 2024
gnalh
added a commit
that referenced
this pull request
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change will help us give users visibility during onboarding.
We can tell them how many uploads calls we've received and how many of them were successful.
This will hopefully translate into less time users have to spend waiting to get value from flaky tests.
Closes TRUNK-12756
Can't be merged until the corresponding API changes (https://github.com/trunk-io/trunk/pull/16848, https://github.com/trunk-io/trunk/pull/16855) are in. The checks will continue to fail until then.