Correct getting affected projects in Nx #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pat-trunk-io
approved these changes
Sep 3, 2024
matt-fff
approved these changes
Sep 3, 2024
| @@ -35,6 +35,8 @@ def fetch_remote_git_history(ref): | |||
| print("No merge instance branch found. Exiting.") | |||
| sys.exit(1) | |||
|
|
|||
| write_to_github_output(f"merge_instance_branch={merge_instance_branch}") | |||
There was a problem hiding this comment.
This, which is called during the prerequisite step of this workflow, is outputting to github's output, which gets passed around between all of the remaining steps in the flow. That's why we switch to passing in steps.prerequisites.outputs.merge_instance_branch for the merge branch for the other steps (link). We do this because providing the merge branch to us is optional - we use the repo's default branch if it isn't provided, and we make the prerequisite step figure that out for us (link)
|
|
||
| affected_json = json.loads(run_command(f"cat {affected_json_out}", return_output=True)) | ||
| affected_list_out = f"./{merge_instance_branch_head_sha}_{pr_branch_head_sha}.txt" | ||
| nx_show_command_base = f"npx nx show projects --affected --base={merge_instance_branch_head_sha} --head={pr_branch_head_sha}" |
There was a problem hiding this comment.
Tested this out locally and it seems to check out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context - the current Nx action didn't work for Nx versions above 19 - this corrects that
Proof of it working with targets -https://github.com/trunk-io/mergequeue-nx/actions/runs/10638401563?pr=207, for PR https://github.com/trunk-io/mergequeue-nx/pull/207
Proof of it working with no targets - https://github.com/trunk-io/mergequeue-nx/actions/runs/10638161072/job/29493542313?pr=208, for PR https://github.com/trunk-io/mergequeue-nx/pull/208
Proof of it working with an impacts all diff - https://github.com/trunk-io/mergequeue-nx/pull/209, for PR https://github.com/trunk-io/mergequeue-nx/pull/209