Reject commands from multiple transports #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apdu-dispatch does not have proper support for multiple concurrent transport since there are no separate selection for each app. The proper solution would be to have separate buffers and selection per transport, but that would also require apps to actually deal with multiple interfaces, which they currently do not. This patch makes it so that the first command sets the used transport, and that any command comming from another transport will be rejected.
robin-nitrokey
approved these changes
Jun 27, 2023
|
But please add a changelog entry. |
Alternatively we could also use only one |
|
Hmm, true. And runners that want to support both at the same time could set up two dispatches. |
robin-nitrokey
added a commit
to Nitrokey/nitrokey-3-firmware
that referenced
this pull request
Oct 25, 2023
This patch updates some of the unreleased dependencies. This pulls in some stack usage optimizations and the change in apdu-dispatch that forbids commands from multiple transports, see: #353 trussed-dev/apdu-dispatch#19
robin-nitrokey
added a commit
to Nitrokey/nitrokey-3-firmware
that referenced
this pull request
Oct 25, 2023
This patch updates some of the unreleased dependencies. This pulls in some stack usage optimizations and the change in apdu-dispatch that forbids commands from multiple transports, see: #353 trussed-dev/apdu-dispatch#19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apdu-dispatch does not have proper support for multiple concurrent transport since there are no separate selection for each app.
The proper solution would be to have separate buffers and selection per transport, but that would also require apps to actually deal with multiple interfaces, which they currently do not.
This patch makes it so that the first command sets the used transport, and that
any command comming from another transport will be rejected.