Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CommandView::to_owned #20

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Refactor CommandView::to_owned #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/command.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,10 +567,12 @@ impl<'a> CommandView<'a> {
p1,
p2,
le,
data,
data: data_slice,
extended,
} = self;
Ok(Command {
// We use this way to construct the command instead of Data::from_slice as that would
// triple stack usage on the lpc55.
let mut command = Command {
// header
class,
instruction,
Expand All @@ -579,9 +581,14 @@ impl<'a> CommandView<'a> {
// maximum expected response length
le,
// payload
data: Data::from_slice(data).map_err(|_| FromSliceError::TooLong)?,
data: Data::new(),
extended,
})
};
command
.data
.extend_from_slice(data_slice)
.map_err(|_| FromSliceError::TooLong)?;
Ok(command)
}
}

Expand Down