Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for more elliptic curves #167

Merged
merged 4 commits into from
Jul 26, 2024
Merged

Conversation

sosthene-nitrokey
Copy link
Contributor

  • p348 (using RustCrypto)
  • p521 (using Ruscrypto)
  • brainpoolP256r1 (Mechanism definition only, implementation in separate backend)
  • brainpoolP384r1 (Mechanism definition only, implementation in separate backend)
  • brainpoolP512r1 (Mechanism definition only, implementation in separate backend)

This PR is the upstream version of #163

Copy link
Member

@robin-nitrokey robin-nitrokey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that the there are no client traits for the brainpool curves. No big issue for me because I don’t really like the API duplication between CryptoClient and the mechanisms. But is there a special reason for that?

Otherwise LGTM.

@sosthene-nitrokey
Copy link
Contributor Author

Good point.

I did not add the client traits because I don't use them in opcard, so they would not end up being used anyway.
We can add them in the future if needed.

@sosthene-nitrokey sosthene-nitrokey merged commit 8b8beee into main Jul 26, 2024
2 checks passed
@sosthene-nitrokey sosthene-nitrokey deleted the more-curves-upstream branch July 26, 2024 13:25
@sosthene-nitrokey sosthene-nitrokey mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants