Update isCustomProps to accept "otherProps" #1194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonlenz
requested review from
ahobson,
gidjin,
haworku,
sarboc,
SirenaBorracha,
suzubara and
tinyels
as code owners
brandonlenz
removed request for
ahobson,
gidjin,
suzubara,
tinyels,
sarboc and
haworku
SirenaBorracha
approved these changes
Apr 29, 2021
SirenaBorracha
merged commit 5922eff
into
ak-update-grid-component-to-take-component-prop-160
SirenaBorracha
added a commit
that referenced
this pull request
Apr 30, 2021
* Update GridContainer to handle any component but default to a div, update tests, update storybook with customContainer story * Combine GridContainer examples in storybook * Update Grid component to render any type of element * Regenerate yarn.lock * Combine custom components into one Storybook example * Remove superfluous li element from custom storybook example * Remove unnecessary spaces from storybook file * Move call to classes function outside of if statement separating default from custom component creation * Update isCustomProps to accept "otherProps" (#1194) * Update isCustomProps to accept "otherProps" * Refactor out ommited props Co-authored-by: Brandon Lenz <brandonalenz@gmail.com>
Merged
SirenaBorracha
added a commit
that referenced
this pull request
May 5, 2021
## [1.17.0](1.16.0...1.17.0) (2021-05-05) ### Features * Checkbox Tile Variant ([#1104](#1104)) ([9936c4a](9936c4a)) * Implement ProcessListHeading subcomponent ([#1162](#1162)) ([964e34c](964e34c)) * New Component ProcessList MVP ([#1107](#1107)) ([1bc0f93](1bc0f93)) * New Component SiteAlert ([#1099](#1099)) ([c1e88e0](c1e88e0)) * New Component SummaryBox ([#1098](#1098)) ([b2279b4](b2279b4)) * Radio Button Tile Variant ([#1101](#1101)) ([a2f40a0](a2f40a0)) * Update Grid components to render any type of element ([#1166](#1166)) ([07468c8](07468c8)), closes [#1194](#1194) * Update Search component to support i18n ([#1192](#1192)) ([5241d15](5241d15)) * Update Table to 2.10.0 implementation ([#1110](#1110)) ([117a6c7](117a6c7))
brandonlenz
added a commit
that referenced
this pull request
May 12, 2021
* Update GridContainer to handle any component but default to a div, update tests, update storybook with customContainer story * Combine GridContainer examples in storybook * Update Grid component to render any type of element * Regenerate yarn.lock * Combine custom components into one Storybook example * Remove superfluous li element from custom storybook example * Remove unnecessary spaces from storybook file * Move call to classes function outside of if statement separating default from custom component creation * Update isCustomProps to accept "otherProps" (#1194) * Update isCustomProps to accept "otherProps" * Refactor out ommited props Co-authored-by: Brandon Lenz <brandonalenz@gmail.com>
brandonlenz
pushed a commit
that referenced
this pull request
May 12, 2021
## [1.17.0](1.16.0...1.17.0) (2021-05-05) ### Features * Checkbox Tile Variant ([#1104](#1104)) ([9936c4a](9936c4a)) * Implement ProcessListHeading subcomponent ([#1162](#1162)) ([964e34c](964e34c)) * New Component ProcessList MVP ([#1107](#1107)) ([1bc0f93](1bc0f93)) * New Component SiteAlert ([#1099](#1099)) ([c1e88e0](c1e88e0)) * New Component SummaryBox ([#1098](#1098)) ([b2279b4](b2279b4)) * Radio Button Tile Variant ([#1101](#1101)) ([a2f40a0](a2f40a0)) * Update Grid components to render any type of element ([#1166](#1166)) ([07468c8](07468c8)), closes [#1194](#1194) * Update Search component to support i18n ([#1192](#1192)) ([5241d15](5241d15)) * Update Table to 2.10.0 implementation ([#1110](#1110)) ([117a6c7](117a6c7))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'm pretty sure we tried almost exactly this a few days ago, but I just gave it another shot and it looks like it works!!
This resolves an issue in #1166 where the omitted props were being spread to the custom rendered element.