Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Checkbox Tile Variant #1104

Merged
merged 7 commits into from
Apr 27, 2021
Merged

feat: Checkbox Tile Variant #1104

merged 7 commits into from
Apr 27, 2021

Conversation

mlm55
Copy link
Contributor

@mlm55 mlm55 commented Apr 8, 2021

Summary

Adds a tile version of the checkbox

Related Issues or PRs

closes: #790

How To Test

yarn test
yarn storybook
Viewable from Form controls > Checkbox > Tile/Tile with label description

Screenshots (optional)

Screen Shot 2021-04-08 at 4 49 24 PM

Screen Shot 2021-04-09 at 3 21 21 PM

@trussworks-infra-zz trussworks-infra-zz temporarily deployed to storybook April 8, 2021 22:12 Inactive
@brandonlenz brandonlenz added the status: hold merge This indicates not to merge the PR as there is a development dependency/other reason to hold off. label Apr 9, 2021
@mlm55 mlm55 marked this pull request as ready for review April 9, 2021 20:24
@trussworks-infra-zz trussworks-infra-zz temporarily deployed to storybook April 9, 2021 20:26 Inactive
@brandonlenz brandonlenz added this to the USWDS 2.10.0 milestone Apr 9, 2021
Copy link
Contributor

@brandonlenz brandonlenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments, then I'm good to approve!

src/components/forms/Checkbox/Checkbox.stories.tsx Outdated Show resolved Hide resolved
src/components/forms/Checkbox/Checkbox.tsx Outdated Show resolved Hide resolved
Co-authored-by: Brandon Lenz <brandonalenz@gmail.com>
@trussworks-infra-zz trussworks-infra-zz temporarily deployed to storybook April 13, 2021 14:46 Inactive
@trussworks-infra-zz trussworks-infra-zz temporarily deployed to storybook April 13, 2021 15:00 Inactive
@brandonlenz brandonlenz added status: approved For PRs that have been reviewed and approved, but may need another approval due to CI and removed status: hold merge This indicates not to merge the PR as there is a development dependency/other reason to hold off. labels Apr 15, 2021
@brandonlenz brandonlenz self-requested a review April 20, 2021 17:32
brandonlenz
brandonlenz previously approved these changes Apr 20, 2021
suzubara
suzubara previously approved these changes Apr 23, 2021
@brandonlenz brandonlenz dismissed stale reviews from suzubara and themself via 9aee21e April 27, 2021 14:38
@trussworks-infra-zz trussworks-infra-zz temporarily deployed to storybook April 27, 2021 14:42 Inactive
Copy link
Contributor

@brandonlenz brandonlenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving post-merge conflicts

@brandonlenz brandonlenz merged commit 9936c4a into main Apr 27, 2021
@brandonlenz brandonlenz deleted the mp-checkbox-tile-790 branch April 27, 2021 14:46
SirenaBorracha added a commit that referenced this pull request May 5, 2021
## [1.17.0](1.16.0...1.17.0) (2021-05-05)


### Features

* Checkbox Tile Variant ([#1104](#1104)) ([9936c4a](9936c4a))
* Implement ProcessListHeading subcomponent ([#1162](#1162)) ([964e34c](964e34c))
* New Component ProcessList MVP ([#1107](#1107)) ([1bc0f93](1bc0f93))
* New Component SiteAlert ([#1099](#1099)) ([c1e88e0](c1e88e0))
* New Component SummaryBox ([#1098](#1098)) ([b2279b4](b2279b4))
* Radio Button Tile Variant ([#1101](#1101)) ([a2f40a0](a2f40a0))
* Update Grid components to render any type of element ([#1166](#1166)) ([07468c8](07468c8)), closes [#1194](#1194)
* Update Search component to support i18n ([#1192](#1192)) ([5241d15](5241d15))
* Update Table to 2.10.0 implementation  ([#1110](#1110)) ([117a6c7](117a6c7))
brandonlenz pushed a commit that referenced this pull request May 12, 2021
brandonlenz pushed a commit that referenced this pull request May 12, 2021
## [1.17.0](1.16.0...1.17.0) (2021-05-05)


### Features

* Checkbox Tile Variant ([#1104](#1104)) ([9936c4a](9936c4a))
* Implement ProcessListHeading subcomponent ([#1162](#1162)) ([964e34c](964e34c))
* New Component ProcessList MVP ([#1107](#1107)) ([1bc0f93](1bc0f93))
* New Component SiteAlert ([#1099](#1099)) ([c1e88e0](c1e88e0))
* New Component SummaryBox ([#1098](#1098)) ([b2279b4](b2279b4))
* Radio Button Tile Variant ([#1101](#1101)) ([a2f40a0](a2f40a0))
* Update Grid components to render any type of element ([#1166](#1166)) ([07468c8](07468c8)), closes [#1194](#1194)
* Update Search component to support i18n ([#1192](#1192)) ([5241d15](5241d15))
* Update Table to 2.10.0 implementation  ([#1110](#1110)) ([117a6c7](117a6c7))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: approved For PRs that have been reviewed and approved, but may need another approval due to CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Tile display variant of checkbox
4 participants