Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Happo failures when referencing external images in storybook #1265

Closed
ahobson opened this issue May 25, 2021 · 0 comments · Fixed by #1266
Closed

Happo failures when referencing external images in storybook #1265

ahobson opened this issue May 25, 2021 · 0 comments · Fixed by #1266

Comments

@ahobson
Copy link
Contributor

ahobson commented May 25, 2021

We've been seeing Happo diffs when referencing external images. Try using base64 images in the stories to remove external dependencies
ahobson pushed a commit that referenced this issue May 25, 2021
fix: Use embedded images for storybook (#1265)
6f5897c
@ahobson ahobson mentioned this issue May 25, 2021
Merged
ahobson pushed a commit that referenced this issue May 25, 2021
fix: Use embedded images for storybook (#1265)
eb4dc51
ahobson pushed a commit that referenced this issue May 27, 2021
fix: Use embedded images for storybook (#1265)
4795af2
ahobson added a commit that referenced this issue May 28, 2021
@ahobson
fix: Use embedded images for storybook (#1265) (#1266)
61abd79
@haworku haworku mentioned this issue Jun 14, 2021
Merged
@brandonlenz brandonlenz mentioned this issue Jun 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Use embedded images for storybook trussworks/react-uswds
1 participant
@ahobson