Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use embedded images for storybook #1266

Merged
merged 1 commit into from
May 28, 2021
Merged

Conversation

ahobson
Copy link
Contributor

@ahobson ahobson commented May 25, 2021

Summary

Try embedded images to fix Happo diffs

Related Issues or PRs

closes #1265

How To Test

See if spurious Happo diffs go away

@ahobson ahobson changed the title fix: Use embedded images for storybook (#1265) fix: Use embedded images for storybook May 25, 2021
@trussworks-infra-zz
Copy link

trussworks-infra-zz commented May 25, 2021

Warnings
⚠️ This PR does not include changes to tests, even though it affects source code.

Generated by 🚫 dangerJS against 4795af2

@trussworks-infra-zz trussworks-infra-zz temporarily deployed to storybook May 25, 2021 19:01 Inactive
@ahobson ahobson force-pushed the adh-storybook-static-1265 branch from 6f5897c to eb4dc51 Compare May 25, 2021 19:37
@trussworks-infra-zz trussworks-infra-zz temporarily deployed to storybook May 25, 2021 19:41 Inactive
Copy link
Contributor

@brandonlenz brandonlenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of questions before I approve, but I'm very excited for this to unblock dependabot updates 😄 🚀 🥳

src/components/card/Card.stories.tsx Show resolved Hide resolved
src/components/card/Card.stories.tsx Show resolved Hide resolved
brandonlenz
brandonlenz previously approved these changes May 27, 2021
@ahobson ahobson force-pushed the adh-storybook-static-1265 branch from eb4dc51 to 4795af2 Compare May 27, 2021 21:17
@trussworks-infra-zz trussworks-infra-zz temporarily deployed to storybook May 27, 2021 21:21 Inactive
@brandonlenz brandonlenz self-requested a review May 28, 2021 14:55
Copy link
Contributor

@brandonlenz brandonlenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ahobson

Looking forward to watching those dependabot PRs fly!

@ahobson ahobson merged commit 61abd79 into main May 28, 2021
@ahobson ahobson deleted the adh-storybook-static-1265 branch May 28, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Happo failures when referencing external images in storybook
3 participants