feat: Modal component #1622
Merged
feat: Modal component #1622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in parent Modal component
…eact-uswds into sr-1233-modal-component
suzubara
commented
Oct 6, 2021
| return <Link<FCProps> {...linkProps} /> | ||
| } | ||
|
|
||
| const definitelyLinkProps = linkProps as DefaultLinkProps |
There was a problem hiding this comment.
This seems to fix the Typescript error that we started seeing in this update - I'm not sure why the overload isn't correctly narrowing this type after the isCustomProps check but I think that is a separate issue to resolve.
brandonlenz
previously approved these changes
Oct 6, 2021
brandonlenz
reviewed
Oct 7, 2021
Co-authored-by: Brandon Lenz <brandonalenz@gmail.com>
brandonlenz
approved these changes
Oct 7, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the USWDS Modal component and adds all USWDS examples to Storybook, as well as some documentation around how to use the component.
I also added focus-trap-react for managing focus inside of modals (USWDS handles this in a util and it seemed like something better implemented with an existing lib).
I also added two components to use for toggling the modal that implement the guidelines suggested by USWDS for convenience:
ModalToggleButtonandModalOpenLink. Consumers can also call the exposed reftoggleModalmethod directly, so they are not restricted to these components.Related Issues or PRs
How To Test
document.body. This is expected.Screenshots (optional)