Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update to USWDS 2.11.2 #1610

Merged
merged 5 commits into from
Oct 5, 2021
Merged

chore: Update to USWDS 2.11.2 #1610

merged 5 commits into from
Oct 5, 2021

Conversation

suzubara
Copy link
Contributor

@suzubara suzubara commented Sep 29, 2021 •
edited
Loading

Summary

This PR updates USWDS to version 2.11.2 and makes minor, non-functional changes to existing components. Any other changes needed to match 2.11 are documented in further issues below.

Updates included are:

Related Issues or PRs

Followup issues for 2.11 updates (not included in this PR):

Closes #1304

How To Test

  • Verify that you are able to use this branch alongside an application using USWDS 2.11 without any issues.

@trussworks-infra-zz
Copy link

trussworks-infra-zz commented Sep 29, 2021 •
edited
Loading

Warnings
⚠️ This PR does not include changes to tests, even though it affects source code.

Generated by 🚫 dangerJS against 0a3c444

@trussworks-infra-zz trussworks-infra-zz temporarily deployed to storybook September 29, 2021 16:59 Inactive
@suzubara suzubara marked this pull request as ready for review September 29, 2021 18:56
@suzubara suzubara added high priority Active blocker for a current project or just urgent type: dependencies Maintaining 3rd-party dependencies uswds update Update to a new USWDS version labels Sep 29, 2021
@suzubara suzubara added this to the USWDS 2.11.x milestone Sep 29, 2021
haworku
haworku approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@haworku haworku left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for organizing this PR well - made it much easier to understand what changes are happening and why ⭐.

Are you planning to use this same text in the release notes? I think we should. For example, even that change to HTML markup I know will break our cypress tests when we upgrade. If I didn't see a link to that diff and your comment I would be wondering why and when things changed.

@suzubara
Copy link
Contributor Author

suzubara commented Oct 4, 2021

Thanks for organizing this PR well - made it much easier to understand what changes are happening and why ⭐.

Are you planning to use this same text in the release notes? I think we should. For example, even that change to HTML markup I know will break our cypress tests when we upgrade. If I didn't see a link to that diff and your comment I would be wondering why and when things changed.

ah that's a good idea! Does this warrant a breaking change? 🤔

@suzubara suzubara mentioned this pull request Oct 4, 2021
Merged
@suzubara suzubara merged commit 6f87276 into main Oct 5, 2021
@suzubara suzubara deleted the sr-1304-uswds-2.11 branch October 5, 2021 15:33
@haworku haworku mentioned this pull request Oct 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haworku haworku haworku approved these changes

@brandonlenz brandonlenz brandonlenz approved these changes

@ahobson ahobson Awaiting requested review from ahobson

@gidjin gidjin Awaiting requested review from gidjin

@sarboc sarboc Awaiting requested review from sarboc

@SirenaBorracha SirenaBorracha Awaiting requested review from SirenaBorracha

Assignees
No one assigned
Labels
high priority Active blocker for a current project or just urgent type: dependencies Maintaining 3rd-party dependencies uswds update Update to a new USWDS version
Projects
None yet
Milestone
USWDS 2.11.x
Development

Successfully merging this pull request may close these issues.

Update to 2.11.x
4 participants
@suzubara @trussworks-infra-zz @haworku @brandonlenz