Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Callout outside contributors process #1969

Merged
merged 5 commits into from
Jun 21, 2022

Conversation

rogeruiz
Copy link
Contributor

@rogeruiz rogeruiz commented Apr 7, 2022

Summary

Outside contributors can submit PRs against but can't have our status checks run on their forked branches due to security concerns. We mitigate these limitations by having documentation around outside contributions. This patch series helps by adding documentation and messaging to outside contributors so that both maintainers and contributors know what next steps are. We can continue fleshing this out going forward as well.

Related Issues or PRs

Refactor the caveat about outside contributors to have a linkable
heading.
@hgarfinkle
Copy link
Contributor

I'm looking at this PR where it looks like a forked branch is having its checks run. Is that supposed to be happening?

@rogeruiz
Copy link
Contributor Author

rogeruiz commented Apr 8, 2022

I'm looking at this PR where it looks like a forked branch is having its checks run. Is that supposed to be happening?

@Igarfinkle
While checks are run, not all checks are run from outside contributors. See my screenshot below for another reference. But the build and danger checks are not run when there are changes from outside contributors.

📷 Screenshot

image

Copy link
Contributor

@brandonlenz brandonlenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this PR is still draft or not, but the verbiage looks good to me.

@rogeruiz rogeruiz marked this pull request as ready for review May 20, 2022 16:53
@rogeruiz rogeruiz requested a review from a user May 20, 2022 16:53
@rogeruiz rogeruiz merged commit 7881191 into main Jun 21, 2022
@rogeruiz rogeruiz deleted the rogeruiz/callout-outside-contributors-process branch June 21, 2022 21:19
@gidjin gidjin mentioned this pull request Jul 13, 2022
gidjin added a commit that referenced this pull request Jul 13, 2022
## [3.1.0](3.0.2...3.1.0) (2022-07-13)


### Features

* Remove example app ([#2162](#2162)) ([1eb579e](1eb579e))
* USWDS 2.13.3 ([#2175](#2175)) ([fdeefc6](fdeefc6))


### Bug Fixes

* Danger contributors check ([#2167](#2167)) ([c05fe06](c05fe06))
* Emit headingLevel type and do not emit type declarations for tests ([#2134](#2134)) ([a4501dd](a4501dd))
* export SummaryBoxHeading and SummaryBoxContent ([#2100](#2100)) ([141ba8e](141ba8e))


### Documentation & Examples

* Callout outside contributors process ([#1969](#1969)) ([7881191](7881191))
* Update releasing docs ([#2018](#2018)) ([6849dda](6849dda))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants