Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docs): Fix typo in Storybook documentation template #1914 #1949

Merged
merged 1 commit into from
Apr 6, 2022
Merged

fix(docs): Fix typo in Storybook documentation template #1914 #1949

merged 1 commit into from
Apr 6, 2022

Conversation

fitiskin
Copy link
Contributor

@fitiskin fitiskin commented Apr 3, 2022 •
edited by brandonlenz
Loading

Summary

Related Issues or PRs

closes #1914

@fitiskin fitiskin requested a review from a user April 3, 2022 18:48
rogeruiz
rogeruiz approved these changes Apr 5, 2022
View reviewed changes
Copy link
Contributor

@rogeruiz rogeruiz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🌈

Thank you @fitiskin. 👀 good catch on this typo.

@brandonlenz
Copy link
Contributor

Security restrictions in our CI will prevent this from easily merging. We can use the process outlined in the comments here to first merge the fork into an unprotected branch, then set up a PR to main.

Makes me wonder if we should just skip Danger for forked PRs (easy to do in Github actions). We'd need to do the same with our CircleCI ephemeral deployments. Not sure if that's possible. Those are the two pieces that block open source contributions.

@rogeruiz
Copy link
Contributor

rogeruiz commented Apr 6, 2022

thanks @brandonlenz I'll take a look at through the comments you linked to and we can work on getting this merged in by the end of today.

@brandonlenz brandonlenz changed the base branch from main to landing-fitiskin-patch-1 April 6, 2022 20:49
@brandonlenz brandonlenz merged commit e04a852 into trussworks:landing-fitiskin-patch-1 Apr 6, 2022
@brandonlenz brandonlenz mentioned this pull request Apr 6, 2022
Merged
brandonlenz added a commit that referenced this pull request Apr 6, 2022
@brandonlenz @fitiskin
fix(docs): Fix typo in Storybook documentation template #1914 (#1949) (…
7438640 
…#1967)

Co-authored-by: Artem Fitiskin <artemfitiskin@gmail.com>
@rogeruiz rogeruiz mentioned this pull request Apr 7, 2022
Merged
@hgarfinkle hgarfinkle mentioned this pull request Apr 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogeruiz rogeruiz rogeruiz approved these changes

@suzubara suzubara Awaiting requested review from suzubara

@gidjin gidjin Awaiting requested review from gidjin

@haworku haworku Awaiting requested review from haworku

@ahobson ahobson Awaiting requested review from ahobson

@brandonlenz brandonlenz Awaiting requested review from brandonlenz

@SirenaBorracha SirenaBorracha Awaiting requested review from SirenaBorracha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fix] Typo in Storybook documentation template
3 participants
@fitiskin @brandonlenz @rogeruiz