Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Language selector for two languages has invalid ARIA attribute #2809

Closed
jaredcunha opened this issue Mar 8, 2024 · 0 comments · Fixed by #2819
Closed

[fix] Language selector for two languages has invalid ARIA attribute #2809

jaredcunha opened this issue Mar 8, 2024 · 0 comments · Fixed by #2819
Assignees
Labels
a11y Relates to accessibility standards and practices type: bug Something isn't working like it's supposed to

Comments

@jaredcunha
Copy link

ReactUSWDS Version & USWDS Version:

There on the two-language variants of the Language Selector (button or link), there is an accessibility defect coming from aria-controls="language-options". An element with id="language-options" would not need to exist for this control.

While aria-controls might not be function, this is showing up as a violation in automated tooling.

To Reproduce
Steps to reproduce the behavior:

  1. Click on the language selector button (or link)
  2. Inspect element
  3. Note the aria-controls attribute

Expected behavior

The aria-controls attribute should not be on this version of the Language Selector

Screenshots

Screenshot 2024-03-08 at 11 20 23 AM

Additional context

Device and Browser Information (please complete the following information if describing a UI bug):

@jaredcunha jaredcunha added the type: bug Something isn't working like it's supposed to label Mar 8, 2024
@werdnanoslen werdnanoslen added the a11y Relates to accessibility standards and practices label Mar 8, 2024
@werdnanoslen werdnanoslen self-assigned this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Relates to accessibility standards and practices type: bug Something isn't working like it's supposed to
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants