Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] StepIndicator has hard-coded English status "[not] completed" #2857

Closed
werdnanoslen opened this issue Mar 26, 2024 · 0 comments · Fixed by #2888 or #2879
Closed

[fix] StepIndicator has hard-coded English status "[not] completed" #2857

werdnanoslen opened this issue Mar 26, 2024 · 0 comments · Fixed by #2888 or #2879
Assignees
@kimallen
Labels
a11y Relates to accessibility standards and practices good first issue Good for newcomers i18n Relates to internationalization or localization standards type: bug Something isn't working like it's supposed to

Comments

@werdnanoslen
Copy link
Contributor

ReactUSWDS Version & USWDS Version:

react-uswds v9

Describe the bug

The StepIndicator has English "completed" and "not completed" hard-coded in its sr-only span, preventing i18n

To Reproduce
Steps to reproduce the behavior:

  1. Use screen reader on an otherwise non-English page
  2. Scan a step indicator with mixed statuses
  3. Hear English words despite translators' best work

Expected behavior

A new statusText prop to pass in for these words

Additional context
#1742
@werdnanoslen werdnanoslen added type: bug Something isn't working like it's supposed to a11y Relates to accessibility standards and practices i18n Relates to internationalization or localization standards good first issue Good for newcomers labels Mar 26, 2024
@kimallen kimallen self-assigned this Apr 12, 2024
@kimallen kimallen mentioned this issue Apr 15, 2024
Merged
kimallen added a commit that referenced this issue Apr 17, 2024
@kimallen
fix: add a statusText prop to StepIndicator to allow for i18n for the…
855205e 
… sr-only element Closes #2857 (#2888)
@github-actions github-actions bot mentioned this issue Apr 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kimallen kimallen

Labels
a11y Relates to accessibility standards and practices good first issue Good for newcomers i18n Relates to internationalization or localization standards type: bug Something isn't working like it's supposed to
Projects
None yet
Milestone
No milestone
2 participants
@werdnanoslen @kimallen