fix: add a statusText prop to StepIndicator to allow for i18n for the sr-only element Closes #2857 #2888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimallen
changed the title
brandonlenz
approved these changes
Apr 17, 2024
|
@all-contributors please add @kimallen for a11y |
|
I've put up a pull request to add @kimallen! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Incorporates the option to use i18n for screen-reader only text regarding the status of each step in the StepIndicator. Updates tests and storybook.
Related Issues or PRs
Closes #2857
How To Test
yarn storybookIn the 'Controls', create a
statusTextobject (ex. {complete: "completado", incomplete: "no completado"}).Using a screen reader, listen to the stated status of each step.
AND/OR
Look at the source code in the developer tools for each of the steps and see the sr-only element with the applied status text.
Screenshots (optional)