Add title component #105
Merged
Add title component #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eamahanna
requested review from
gidjin,
sarboc,
suzubara and
tinyels
as code owners
Closed
haworku
reviewed
Apr 27, 2020
src/components/Title/Title.tsx
Outdated
| return ( | ||
| <div className={classes}> | ||
| <em className="usa-logo__text"> | ||
| <a href={link}>{title}</a> |
There was a problem hiding this comment.
A couple things.
- 🤔 This very much feels like it should be a
<h1>.I wonder whyFound discussion of theemis being used by the uswds design team...emversush1in their docs which links here. - As written,
linkprop could be undefined - we should probably not wrap the text in an anchor tag in the first place for those cases.
haworku
reviewed
Apr 27, 2020
src/components/Title/Title.tsx
Outdated
|
|
||
| return ( | ||
| <div className={classes}> | ||
| <h1 className="usa-logo__text">{title}</h1> |
There was a problem hiding this comment.
Suggested change
| <h1 className="usa-logo__text">{title}</h1> | |
| link? | |
| <h1 className="usa-logo__text"> | |
| <a href={link}>{title}</a> | |
| </h1> | |
| : <h1 className="usa-logo__text">{title}</h1> |
Oops! My comment was unclear. What you had before was good, just conditionally display the link. Only include it when it exists. If it doesn't exist, leave it out .
There was a problem hiding this comment.
I think we should avoid rendering <a> in general since we don't know what kind of routing a user is using. Also if we do want to render <a> we need to allow for element attributes to be passed in
suzubara
reviewed
Apr 27, 2020
There was a problem hiding this comment.
Sorry it took me awhile to get to this 🤦♀️ I have some suggestions:
- Should we call this component
HeaderTitleor maybeHeaderLogo? I'm thinking for clarity purposes, because this component does not exist outside of the context of the header on the USWDS site, and so it may not work as expected if it's not rendered inside of the header. Or it could be located insidecomponents/Header. - Here are my 2 cents on
h1vsem: by default we should render<em class="usa-logo__text">in this component since that follows the examples from https://designsystem.digital.gov/components/header/ . However the name of that CSS class implies there could be another type of logo, such as an image. So we might want to think about how to allow other kinds of titles/logos to be passed in (such as an h1 or an image) in the future. Call me crazy but we could go as far as creating aLogocomponent which renders the<div class="usa-logo">for positioning, and aTextLogocomponent which renders<em class="usa-logo__text">for default text styling. - Since the purpose of this component is to render its contents, IMO the title should be passed in as
childreninstead of a prop. So rendering this component would look like
<Title>Test Title</Title>
When I merge this branch into my main header branch, I will move the title into the header folder. |
suzubara
reviewed
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This PR adds the Title component. This component may be used through out an application, and is included in the USWDS Header Component: https://designsystem.digital.gov/components/header/
For Reviewers
Should this component be composed in an alternate manner to make it more reuse-able?
To test this component execute the following commands in the react-uswds repo:
Navigate to the Title component.