Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: New Component SummaryBox #1098
feat: New Component SummaryBox #1098
Changes from 20 commits
0a0badd
153d8c7
a8b832e
d638a66
41d4607
584eaa2
c72a93e
d5914df
3d54e2f
8d9197b
7fe9f9b
fdd9844
45ec45a
08d1f44
1035f36
2df35fd
6cd9ee0
f837bf5
837e030
fc36dbd
d3f0a71
b33b32f
38d71d9
f09557d
20e5531
2c10c14
0ee3600
9009665
8ef404d
49bde97
a8c437a
e16c5d5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: can we name this
Components / Summary box
so it matches the USWDS name?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like this
<div className="usa-summary-box__text">
is repeated in the Story (since it's also rendered in the component itself) - can we remove?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add a check for custom
className
here too.