build(deps-dev): Update Typescript to 4.0+ #1214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… all type check warnings and errors
ghost
added
the
type: breaking
ghost
requested review from
ahobson,
brandonlenz,
gidjin,
haworku,
sarboc,
SirenaBorracha,
suzubara and
tinyels
as code owners
Closed
brandonlenz
approved these changes
May 10, 2021
brandonlenz
pushed a commit
that referenced
this pull request
May 12, 2021
brandonlenz
pushed a commit
that referenced
this pull request
May 12, 2021
Merged
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updates the React-USWDS Typescript version to 4.0 (actually 4.2.4, which is the most recent TS version, and also what USWDS is using in their latest release). This required updating the
@typescript-eslintplugin and parser, which required changing some linter exception comments in a story file to solve an eslint error that arose with the plugin version change.The updated plugin also threw quite a few warnings around wanting
argTypesparameters in story files to be typed, so I went ahead and added those, and fixed a few other minor type-checking complaints that existed elsewhere to get back to a warning-free baseline.As we're updating a dependency major version, this is a BREAKING CHANGE.
Related Issues or PRs
Closes #522.
How To Test
yarn testandyarn lint, and make sure everything comes back clean.Tablecomponent has a few) and ensure that toggling control values updates the presentation of the component in the story canvas.