feat: SiteAlert child enhancement #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
ahobson,
brandonlenz,
gidjin,
haworku,
sarboc,
SirenaBorracha,
suzubara and
tinyels
as code owners
ghost
linked an issue
haworku
approved these changes
May 21, 2021
haworku
added
the
status: stale
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Modifies the
SiteAlertcomponent to also accept simple text strings and multiple components as children. If the child is a simple string, the component will wrap it in<p className="usa-alert__text">, which aligns with what the USWDS component is doing. (Single child components and multiple child components are deliberately left alone, as users may already be passing in content for the alert wrapped in aptag.)There is a desire to further enhance this functionality by creating an
AlertTextsub-component, but as I'm still trying to figure out how that could practically work (as it's possible to also use it in theAlertcomponent as well but that might introduce a breaking change?), I'm making this intermediate PR since it's already a value add at this point.Related Issues or PRs
Addresses (but does not fully close, see above + issue discussion) #1191
How To Test
Check out this branch, run
yarn testto execute tests, andyarn storybookto see the updated component functionality in the additional stories for theSiteAlertcomponent.