Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add medium footer #126

Merged
merged 7 commits into from
May 5, 2020
Merged

Add medium footer #126

merged 7 commits into from
May 5, 2020

Conversation

haworku
Copy link
Contributor

@haworku haworku commented Apr 30, 2020

Add medium styles to Footer

  • Add FooterNav, SocialLinks components
  • Add handling for medium styles to Footer
  • Add Medium Footer story

PR (2 of 3) for #78

@haworku haworku changed the title Add medium styles Footer Add medium footer Apr 30, 2020
- serve static files via directory as per storybook docs
- include story for slim logo only, other types to be added in future
@trussworks-infra-zz
Copy link

trussworks-infra-zz commented Apr 30, 2020

Warnings
⚠️ Please add a changelog entry for your changes.

Generated by 🚫 dangerJS against 6809831

Copy link
Contributor

@suzubara suzubara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!!

@haworku haworku changed the base branch from hw-footer-slim to hw-footer May 5, 2020 14:25
@haworku haworku merged commit 544ddde into hw-footer May 5, 2020
@haworku haworku deleted the hw-footer-medium branch May 5, 2020 15:10
haworku added a commit that referenced this pull request May 5, 2020
* Add FooterNav, SocialLinks components 
* Add medium Footer story
* Add medium styles to Logo, Address components
haworku added a commit that referenced this pull request May 5, 2020
* Add FooterNav, SocialLinks components 
* Add medium Footer story
* Add medium styles to Logo, Address components
haworku added a commit that referenced this pull request May 11, 2020
* Add FooterNav, SocialLinks components 
* Add medium Footer story
* Add medium styles to Logo, Address components
haworku added a commit that referenced this pull request May 11, 2020
* Add FooterNav, SocialLinks components
* Add medium Footer story
* Add medium styles to Logo, Address components
haworku added a commit that referenced this pull request May 19, 2020
* Add FooterNav, SocialLinks components
* Add medium Footer story
* Add medium styles to Logo, Address components
haworku added a commit that referenced this pull request May 22, 2020
* Add FooterNav, SocialLinks components
* Add medium Footer story
* Add medium styles to Logo, Address components
suzubara pushed a commit that referenced this pull request May 22, 2020
* Add FooterNav, SocialLinks components
* Add medium Footer story
* Add medium styles to Logo, Address components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants