-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add medium footer #126
Merged
Merged
Add medium footer #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haworku
requested review from
gidjin,
sarboc,
suzubara and
tinyels
as code owners
April 30, 2020 19:09
- serve static files via directory as per storybook docs - include story for slim logo only, other types to be added in future
haworku
force-pushed
the
hw-footer-medium
branch
from
April 30, 2020 21:12
be6faad
to
3e6dd78
Compare
suzubara
approved these changes
May 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good!!
haworku
added a commit
that referenced
this pull request
May 5, 2020
* Add FooterNav, SocialLinks components * Add medium Footer story * Add medium styles to Logo, Address components
haworku
added a commit
that referenced
this pull request
May 5, 2020
* Add FooterNav, SocialLinks components * Add medium Footer story * Add medium styles to Logo, Address components
haworku
added a commit
that referenced
this pull request
May 11, 2020
* Add FooterNav, SocialLinks components * Add medium Footer story * Add medium styles to Logo, Address components
haworku
added a commit
that referenced
this pull request
May 11, 2020
* Add FooterNav, SocialLinks components * Add medium Footer story * Add medium styles to Logo, Address components
haworku
added a commit
that referenced
this pull request
May 19, 2020
* Add FooterNav, SocialLinks components * Add medium Footer story * Add medium styles to Logo, Address components
haworku
added a commit
that referenced
this pull request
May 22, 2020
* Add FooterNav, SocialLinks components * Add medium Footer story * Add medium styles to Logo, Address components
suzubara
pushed a commit
that referenced
this pull request
May 22, 2020
* Add FooterNav, SocialLinks components * Add medium Footer story * Add medium styles to Logo, Address components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add medium styles to Footer
FooterNav
,SocialLinks
componentsFooter
PR (2 of 3) for #78