Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add aria attributes to RangeInput #1560

Merged
merged 10 commits into from
Sep 20, 2021
Merged

feat: Add aria attributes to RangeInput #1560

merged 10 commits into from
Sep 20, 2021

Commits on Sep 9, 2021

  1. Add min and aria min label and tests

    @kimallen
    kimallen committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    b95a414 View commit details
    Browse the repository at this point in the history

  2. Add max values and tests

    @kimallen
    kimallen committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    d45d5bd View commit details
    Browse the repository at this point in the history

  3. Use min value that corresponds to step in test

    @kimallen
    kimallen committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    9a8ec32 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2021

  1. Apply aria value now based on current value

    @kimallen
    kimallen committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    5985310 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2021

  1. Fix value calculation and typing

    @kimallen
    kimallen committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    2c072d1 View commit details
    Browse the repository at this point in the history

  2. Add .idea to .gitignore

    @kimallen
    kimallen committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    51a83ef View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2021

  1. Add option for aria- labels and tests 

    	labels: aria-valuemin, aria-valuemax, aria-valuenow
	tests for correct default value and passed in aria- labels
    @kimallen
    kimallen committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    a9aded6 View commit details
    Browse the repository at this point in the history

  2. Fix default value formula

    @kimallen
    kimallen committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    e188c71 View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2021

  1. refer to aria props via snakecase - e.g. 'aria-valuenow' - strings ra… 

    …ther than React camel case
    @haworku
    haworku committed Sep 17, 2021
    Configuration menu
    Copy the full SHA
    1b550b2 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2021

  1. Merge branch 'main' into kma-rangeinput-aria-labels-1542

    @kimallen
    kimallen committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    a675a16 View commit details
    Browse the repository at this point in the history