fix: Control ComboBox scroll with scrollTop instead of scrollIntoView #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suzubara
requested review from
ahobson,
brandonlenz,
gidjin,
haworku,
sarboc and
SirenaBorracha
as code owners
suzubara
added
high priority
brandonlenz
approved these changes
Oct 25, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR modifies how the ComboBox component scrolls to a focused option when opening the list to use the
scrollTopproperty of the list element instead ofscrollIntoView. This fixes an issue where the whole page would jump when opening the combo box if it was scrolled down (#1693).Related Issues or PRs
Fixes #1693
How To Test
Screenshots (optional)
Fixed in my application: