-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release: 1.3.0 #186
release: 1.3.0 #186
Conversation
Add searchInput component
Bumps [@babel/core](https://github.com/babel/babel) from 7.9.0 to 7.9.6. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/master/CHANGELOG.md) - [Commits](babel/babel@v7.9.0...v7.9.6) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [lint-staged](https://github.com/okonet/lint-staged) from 10.1.7 to 10.2.2. - [Release notes](https://github.com/okonet/lint-staged/releases) - [Commits](lint-staged/lint-staged@v10.1.7...v10.2.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [sass](https://github.com/sass/dart-sass) from 1.26.3 to 1.26.5. - [Release notes](https://github.com/sass/dart-sass/releases) - [Changelog](https://github.com/sass/dart-sass/blob/master/CHANGELOG.md) - [Commits](sass/dart-sass@1.26.3...1.26.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [eslint-config-prettier](https://github.com/prettier/eslint-config-prettier) from 6.10.1 to 6.11.0. - [Release notes](https://github.com/prettier/eslint-config-prettier/releases) - [Changelog](https://github.com/prettier/eslint-config-prettier/blob/master/CHANGELOG.md) - [Commits](prettier/eslint-config-prettier@v6.10.1...v6.11.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 2.30.0 to 2.31.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v2.31.0/packages/parser) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [eslint-plugin-react-hooks](https://github.com/facebook/react/tree/HEAD/packages/eslint-plugin-react-hooks) from 3.0.0 to 4.0.0. - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/master/packages/eslint-plugin-react-hooks/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/HEAD/packages/eslint-plugin-react-hooks) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 2.30.0 to 2.31.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v2.31.0/packages/eslint-plugin) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [webpack](https://github.com/webpack/webpack) from 4.42.1 to 4.43.0. - [Release notes](https://github.com/webpack/webpack/releases) - [Commits](webpack/webpack@v4.42.1...v4.43.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [@types/react-dom](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-dom) from 16.9.6 to 16.9.7. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-dom) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [prettier](https://github.com/prettier/prettier) from 2.0.4 to 2.0.5. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/master/CHANGELOG.md) - [Commits](prettier/prettier@2.0.4...2.0.5) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [@testing-library/react](https://github.com/testing-library/react-testing-library) from 10.0.3 to 10.0.4. - [Release notes](https://github.com/testing-library/react-testing-library/releases) - [Changelog](https://github.com/testing-library/react-testing-library/blob/master/CHANGELOG.md) - [Commits](testing-library/react-testing-library@v10.0.3...v10.0.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [jest](https://github.com/facebook/jest) from 25.4.0 to 25.5.4. - [Release notes](https://github.com/facebook/jest/releases) - [Changelog](https://github.com/facebook/jest/blob/master/CHANGELOG.md) - [Commits](jestjs/jest@v25.4.0...v25.5.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Upgrade to Node v12 and updated relevant docs
feat: add Grid components #86
Updated release flow #118
Bumps [@types/jest](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/jest) from 25.2.1 to 25.2.3. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/jest) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 2.32.0 to 2.34.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v2.34.0/packages/eslint-plugin) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [stylelint](https://github.com/stylelint/stylelint) from 13.3.3 to 13.4.1. - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/master/CHANGELOG.md) - [Commits](stylelint/stylelint@13.3.3...13.4.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [eslint-plugin-react-hooks](https://github.com/facebook/react/tree/HEAD/packages/eslint-plugin-react-hooks) from 4.0.0 to 4.0.2. - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/master/packages/eslint-plugin-react-hooks/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/HEAD/packages/eslint-plugin-react-hooks) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [typescript](https://github.com/Microsoft/TypeScript) from 3.8.3 to 3.9.2. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](microsoft/TypeScript@v3.8.3...v3.9.2) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [eslint-plugin-react](https://github.com/yannickcr/eslint-plugin-react) from 7.19.0 to 7.20.0. - [Release notes](https://github.com/yannickcr/eslint-plugin-react/releases) - [Changelog](https://github.com/yannickcr/eslint-plugin-react/blob/master/CHANGELOG.md) - [Commits](jsx-eslint/eslint-plugin-react@v7.19.0...v7.20.0) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 2.32.0 to 2.34.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v2.34.0/packages/parser) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Bumps [lint-staged](https://github.com/okonet/lint-staged) from 10.2.2 to 10.2.4. - [Release notes](https://github.com/okonet/lint-staged/releases) - [Commits](lint-staged/lint-staged@v10.2.2...v10.2.4) Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
export { PrimaryNav } from './components/header/PrimaryNav/PrimaryNav' | ||
export { Title } from './components/header/Title/Title' | ||
|
||
export { Search } from './components/Search/Search' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this basically a hotfix to the release branch only? The code/commit is not current on develop
. I only notice because I've been having conflicts in my work on index.ts
so been looking at this file a lot. 😅
Also... I wonder if we should just alphabetize (with a tool or manually) this file to avoid conflicts in here due to formatting. Its easy to miss something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also when there are changes only to the release branch that aren't just semantic versioning changes -- Let's call it out in the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup it was a hotfix I noticed.. adding to the PR!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made a comment about release flow stuff but approving- I pulled down the code and checked it out as well.
1.3.0 (2020-05-19)
Features
Other changes (not included in CHANGELOG):
css-modules-typescript-loader
, use generic types insteadAlso fixed the Search input not being exported from the library as a hotfix on this branch.