Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Fix Prettier bracket lines #2073

Merged
merged 3 commits into from
May 13, 2022
Merged

ci: Fix Prettier bracket lines #2073

merged 3 commits into from
May 13, 2022

Conversation

brandonlenz
Copy link
Contributor

@brandonlenz brandonlenz commented May 9, 2022 •
edited
Loading

Summary

Prettier was using a deprecated prop jsxSameLine in .prettierrc, which the VS Code prettier extension no longer respected. This means that the extension would format files differently than code linting tools

Source:

How To Test

  • Verify visually, the bracket styling is still the library's preferred style.
  • Since this runs as a pre-commit hook, and I did not bypass hooks, what is committed is how prettier would format files on anyone's machine

@brandonlenz brandonlenz requested a review from a user May 9, 2022 15:26
@brandonlenz brandonlenz requested a review from rogeruiz as a code owner May 9, 2022 15:26
@brandonlenz brandonlenz changed the title Fix Prettier bracket lines ci: Fix Prettier bracket lines May 9, 2022
@brandonlenz brandonlenz merged commit 25af683 into main May 13, 2022
@brandonlenz brandonlenz deleted the bl-prettier-fixes branch May 13, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haworku haworku haworku approved these changes

@suzubara suzubara Awaiting requested review from suzubara

@gidjin gidjin Awaiting requested review from gidjin

@ahobson ahobson Awaiting requested review from ahobson

@SirenaBorracha SirenaBorracha Awaiting requested review from SirenaBorracha

@rogeruiz rogeruiz Awaiting requested review from rogeruiz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brandonlenz @haworku @trussworks-infra-zz