feat: Add Pagination component #2188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcbcapps
requested review from
gidjin,
haworku,
ahobson,
brandonlenz and
SirenaBorracha
as code owners
gidjin
reviewed
Sep 12, 2022
gidjin
reviewed
Sep 16, 2022
| @@ -235,6 +235,33 @@ describe('Pagination component', () => { | |||
| expect(screen.getAllByText('…')).toHaveLength(1) | |||
| }) | |||
|
|
|||
| it('can click onClickNext, onClickPrevious and onClickPagenumber', () => { | |||
48 tasks
Merged
48 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new Pagination component.
This is a port of the Pagination component that was built for the USSF Portal. I also wanted to note that I followed the instructions here and used
yarn linkto successfully test the component in the USSF Portal.Related Issues or PRs
closes: #1543
How To Test
yarn storybookand look atComponents/Pagination/Sandboxand change some of the controls to see how the component adjusts.yarn test:coverageand verify that all tests are passing and that the coverage threshold is being met.Screenshots: