feat: Make search component extendable #2230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pearl-truss
requested review from
ahobson,
rogeruiz,
gidjin,
haworku,
brandonlenz,
SirenaBorracha and
a user
pearl-truss
changed the title
NamibiaTorres
previously approved these changes
Dec 14, 2022
gidjin
previously approved these changes
Dec 14, 2022
| import { render } from '@testing-library/react' | ||
| import { SearchField } from './SearchField' | ||
|
|
||
| describe('SearchField component', () => { |
There was a problem hiding this comment.
question: I wonder if it's possible/worth the time to add a test ensuring that the new inputProps are passed down as expected? I can go either way on it so I'll leave it up to you :)
There was a problem hiding this comment.
Thanks for the review! I'll add additional test before I merge this
… pm-make-search-component-extendable
pearl-truss
dismissed stale reviews from gidjin and NamibiaTorres
via
82408c0
|
@gidjin @NamibiaTorres I added the additional test. However, I'm seeing a build issue that I can't reproduce locally, it seems to be a CircleCI environment issue. I found some context here. If either of you have seen this issue before please let me know, I'm not sure how to proceed |
gidjin
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR:
inputPropstoSearchand passes it down toTextInputSearchinto two new componentsSearchFieldandSearchButtonRelated Issues or PRs
closes #2209
How To Test
yarn storybookand look atComponents/Search/*notice the search input and search buttons have been broken out into their own components. And are composed together inSearchyarn test:coverageand verify that all tests are passing and that the coverage threshold is being met.Screenshots (optional)
SearchField
SearchButton
Search