Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Replace Table's fullWidth custom style with USWDS utility class #2268

Closed
wants to merge 5 commits into from
Closed

refactor: Replace Table's fullWidth custom style with USWDS utility class #2268

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ddcc89a
Use utility class for full width
sawyerh Feb 25, 2023
e8323a9
Add className prop to Table
sawyerh Feb 25, 2023
7b9e3d7
Remove className prop from this branch
sawyerh Feb 25, 2023
9e86fec
Add test
sawyerh Feb 25, 2023
4a81b1b
Merge branch 'main' into sawyerh/2178-table-fullWidth
haworku Mar 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions src/components/Table/Table.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,3 @@
.fullwidth {
width: 100%;
}

.fixed {
table-layout: fixed;
}
6 changes: 6 additions & 0 deletions src/components/Table/Table.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,12 @@ describe('Table component', () => {
expect(getByRole('table')).toHaveClass('usa-table usa-table--compact')
})

it('renders full width table', () => {
const { getByRole } = render(<Table fullWidth>{testContent}</Table>)

expect(getByRole('table')).toHaveClass('usa-table width-full')
})

it('renders scrollable table', () => {
const { queryByTestId } = render(<Table scrollable>{testContent}</Table>)

Expand Down
2 changes: 1 addition & 1 deletion src/components/Table/Table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export const Table = ({
}: TableProps): React.ReactElement => {
const classes = classnames('usa-table', {
'usa-table--borderless': !bordered,
[`${styles.fullwidth}`]: fullWidth,
'width-full': fullWidth,
[`${styles.fixed}`]: fixed,
'usa-table--striped': striped,
'usa-table--compact': compact,
Expand Down