Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Replace Table's fullWidth custom style with USWDS utility class #2316

Merged
merged 6 commits into from
Mar 28, 2023
Merged

refactor: Replace Table's fullWidth custom style with USWDS utility class #2316

merged 6 commits into from
Mar 28, 2023

Conversation

haworku
Copy link
Contributor

@haworku haworku commented Mar 27, 2023 •
edited
Loading

Summary

Related Issues or PRs

#2178

How To Test

Screenshots (optional)

CleanShot 2023-02-25 at 13 49 50@2x

@haworku haworku requested a review from a user March 27, 2023 14:57
@haworku haworku changed the title feat: Add className prop to Table component refactor: Replace Table's fullWidth custom style with USWDS utility class Mar 27, 2023
rogeruiz
rogeruiz previously approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@rogeruiz rogeruiz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 🌈

Thank you @haworku. And thank you as well @sawyerh for the original work on this.

@github-actions
Copy link
Contributor

Warnings
⚠️ This PR does not include changes to storybook, even though it affects component code.

Generated by 🚫 dangerJS against d109251

@haworku haworku requested a review from rogeruiz March 27, 2023 22:23
gidjin
gidjin approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@gidjin gidjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haworku haworku merged commit ea102ff into main Mar 28, 2023
@haworku haworku deleted the trigger-integration branch March 28, 2023 15:21
@haworku haworku mentioned this pull request Mar 29, 2023
Closed
@haworku
Copy link
Contributor Author

haworku commented Mar 29, 2023

This work also resolves #2178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gidjin gidjin gidjin approved these changes

@ahobson ahobson Awaiting requested review from ahobson

@brandonlenz brandonlenz Awaiting requested review from brandonlenz

@SirenaBorracha SirenaBorracha Awaiting requested review from SirenaBorracha

@jcbcapps jcbcapps Awaiting requested review from jcbcapps

@rogeruiz rogeruiz Awaiting requested review from rogeruiz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@haworku @rogeruiz @gidjin @sawyerh