fix: misapplied attribute #2396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
werdnanoslen
requested review from
gidjin,
haworku,
ahobson,
brandonlenz and
SirenaBorracha
as code owners
brandonlenz
approved these changes
May 9, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
USWDS's accordion component has a 'multiselectable' variant, however that is different from the aria-multiselectable attribute. The latter is used for elements that are selectable (e.g. in a
<select>) to some other end, whereas the former is simply toggled open/closed to its own end. As such, I replaced thearia-multiselectableattribute withdata-allow-multipleas USWDS intended.Related Issues or PRs
Resolves #2204
How To Test
Open Axe on Chrome and inspect the multiselectable accordion page to find no errors:
Screenshots (optional)