Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Exclude placeholder prop from Modal props #2727

Closed
wants to merge 3 commits into from

Commits on Jan 22, 2024

  1. fix: Exclude placeholder prop from Modal props

    The types generated for Modal props indicates that placeholder is
    available because @react/types prior to v18.2.43 has placeholder as an
    attribute in HTMLAttributes. Beginning with @react/types v18.2.43, the
    placeholder attribute has been removed from HTMLAttributes. As a result,
    projects that consume this package but are themselves on @react/types
    v18.2.43 or newer no longer recognize placeholder as an optional
    property; they see it as stemming from these Modal props rather than
    JSX.IntrinsicElements['div'], and that it is required, not optional.
    
    Patch Modal to manually omit placeholder from available properties
    without updating packages, which would require a more significant lift.
    
    Ref: DefinitelyTyped/DefinitelyTyped#67170
    mdmower-csnw committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    30826af View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2024

  1. Configuration menu
    Copy the full SHA
    3e5b2df View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d2512fa View commit details
    Browse the repository at this point in the history