fix: Adds yarn as a devDep #2751
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would be appreciated. It was a necessary addition to our (hopefully temporary) fork in order for CI agents to run |
|
I added this change in #2716 in case that PR lands before this one to ensure folks get it asap |
|
We're in the process of (pending some Github action changes) merging #2716 with this change incorporated, so I'm going to close this PR. Thanks for this @dakota002! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds yarn as a dev dependency. If you install a version of this package from git, (ex. github:lpsinger/react-uswds#dateFormat) the
preparescript will run onnpm install. This causes npm install to fail if yarn is not present on the user's machine.From the npm docs:
NOTE: If a package being installed through git contains a prepare script, its dependencies and devDependencies will be installed, and the prepare script will be run, before the package is packaged and installed.