Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Link Component #161 #309

Merged
merged 13 commits into from
Jul 15, 2020
Merged

feat: Link Component #161 #309

merged 13 commits into from
Jul 15, 2020

Commits on Jul 13, 2020

  1. Add link component, use createElement

    @haworku
    haworku committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    d97388b View commit details
    Browse the repository at this point in the history

  2. only pass needed props in test example

    @haworku
    haworku committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    4d4b513 View commit details
    Browse the repository at this point in the history

  3. fix: Use overloads to narrow type as expected for anchor tags

    @haworku
    haworku committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    7479083 View commit details
    Browse the repository at this point in the history

  4. maybe working custom link

    @haworku
    Andrew Hobson authored and haworku committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    83b67d5 View commit details
    Browse the repository at this point in the history

  5. Working all the way

    @haworku
    Andrew Hobson authored and haworku committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    78122a6 View commit details
    Browse the repository at this point in the history

  6. Support styling custom link components

    @haworku
    Andrew Hobson authored and haworku committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    0ec8fac View commit details
    Browse the repository at this point in the history

  7. Cleanup 

    - add test for children button text
- seperate tests for Link style and asCustom own props
- add back 'required' anchor tag props
-  fix type warning on linkClasses return
    @haworku
    haworku committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    6962763 View commit details
    Browse the repository at this point in the history

  8. Clean up Link types, add overload function signatures

    @haworku
    Andrew Hobson authored and haworku committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    efcaa49 View commit details
    Browse the repository at this point in the history

  9. Storybook + visited links are a TODO item

    @haworku
    Andrew Hobson authored and haworku committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    37db972 View commit details
    Browse the repository at this point in the history

  10. Remove dupe children from Link types

    @haworku
    Andrew Hobson authored and haworku committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    6d4ab9e View commit details
    Browse the repository at this point in the history

  11. Add example of using Link with react-router-dom in the example app

    @haworku
    Suzanne Rozier authored and haworku committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    a90c3d5 View commit details
    Browse the repository at this point in the history

  12. fix: visited/default link styles working with custom-styles.scss

    @haworku
    haworku committed Jul 13, 2020
    Configuration menu
    Copy the full SHA
    813c393 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2020

  1. Merge branch 'main' into adh-link-component-ideas

    @haworku
    haworku authored Jul 14, 2020
    Configuration menu
    Copy the full SHA
    91b7da5 View commit details
    Browse the repository at this point in the history