docs(storybook): Upgrade to 6.0.12 #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use built-in Typescript support * Convert to Typescript for config files * Remove Modal exported types from index.ts to silence storybook warnings. The types are still exported from Modal.ts
ahobson
requested review from
gidjin,
haworku,
sarboc,
suzubara and
tinyels
as code owners
|
Hmm, if I'm changing the exports in |
haworku
requested changes
Aug 18, 2020
There was a problem hiding this comment.
Oo I like the way it looks!
But yes, @ahobson this is a breaking change as written. I think the workaround is just exporting our types differently. See webpack/webpack#7378 (comment) . We can't bulk export a mixture of constants and type interfaces.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
warnings.
Related Issues or PRs
closes #417
How To Test
Confirm the Happo tests pass