Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

combine upgrades from PRS 60-70 #71

Merged
merged 1 commit into from
Apr 14, 2020
Merged

combine upgrades from PRS 60-70 #71

merged 1 commit into from
Apr 14, 2020

Conversation

tinyels
Copy link
Contributor

@tinyels tinyels commented Apr 14, 2020 •
edited
Loading

Trying to streamline getting the dependabot changes in without having to deal with yarn.lock conflicts manually.

There is one outstanding audit issue, but @storybook/addon-info doesn't have an upgrade available yet.
image

gidjin
gidjin approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@gidjin gidjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks for updating these! I ran yarn install, test, and storybook locally everything seemed good.

@tinyels tinyels merged commit beb7f12 into develop Apr 14, 2020
@tinyels tinyels deleted the els_combine_dependabot_branches branch April 14, 2020 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gidjin gidjin gidjin approved these changes

@sarboc sarboc Awaiting requested review from sarboc

@suzubara suzubara Awaiting requested review from suzubara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tinyels @gidjin