This repository has been archived by the owner on Aug 25, 2023. It is now read-only.
fix: term expansion alignment #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llorllale
force-pushed
the
expand_relyingparty_attr
branch
from
99e6b07 to
ced95e8
Compare
troyronda
reviewed
Jul 29, 2020
| @@ -24,8 +24,8 @@ | |||
| "@id":"ex:issuerDIDDoc", | |||
| "@type":"DIDDoc" | |||
| }, | |||
| "rpDIDDoc":{ | |||
| "@id":"ex:rpDIDDoc", | |||
| "relyingPartyDIDDoc":{ | |||
There was a problem hiding this comment.
As this authorization credential is not coupled to OIDC, we might want to use the DID core spec language:
requestingParty
There was a problem hiding this comment.
I'd say we align ourselves with UMA (where it's also "requestingParty")
There was a problem hiding this comment.
@troyronda changed to requestingPartyDID but thinking about this has resurfaced old thoughts and ideas that you and I may have discussed - I opened several issues: #23, #24, #25
Signed-off-by: George Aristy <george.aristy@securekey.com>
llorllale
force-pushed
the
expand_relyingparty_attr
branch
from
ced95e8 to
35f0305
Compare
troyronda
approved these changes
Jul 29, 2020
rolsonquadras
approved these changes
Jul 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expanding
rpDIDDoc->relyingPartyDIDDocto align with the other terms.Signed-off-by: George Aristy george.aristy@securekey.com