Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review rule for "kid MUST be present in the protected header" #365

Closed
sandrask opened this issue Aug 5, 2020 · 2 comments · Fixed by #476
Closed

Review rule for "kid MUST be present in the protected header" #365

sandrask opened this issue Aug 5, 2020 · 2 comments · Fixed by #476
Assignees
@sandrask
Labels
chore
Milestone
0.1.5

Comments

@sandrask
Copy link
Contributor

sandrask commented Aug 5, 2020 •
edited
Loading

There is discrepancy between spec "kid MUST be present in the protected header" and reference implementation that expects only one 'alg' header. If I implement spec version interop tests are failing.

https://github.com/decentralized-identity/sidetree/blob/0dbf2c8ce6ef8981ebc6735066841bce39e2648f/lib/core/versions/latest/util/Jws.ts#L40

// TODO: There is discrepancy between spec "kid MUST be present in the protected header"

sidetree-core-go/pkg/operation/recover.go

Line 127 in 79fd877

// TODO: There is discrepancy between spec "kid MUST be present in the protected header"

@troyronda
Copy link
Contributor

decentralized-identity/sidetree#841

@sandrask
Copy link
Contributor Author

The spec was changed to "kid MAY be present in the protected header" - will remove commented out code and issue reference from the code.

@sandrask sandrask self-assigned this Nov 15, 2020
@sandrask sandrask added the chore label Nov 15, 2020
@sandrask sandrask added this to the 0.1.5 milestone Nov 15, 2020
sandrask added a commit to sandrask/sidetree-core-go that referenced this issue Nov 15, 2020
@sandrask
chore: remove references to kid MUST be present in protected headers
39adf77 
Spec has been updated to "kid MAY be present in the protected headers". Remove commented out code.

Closes trustbloc#365

Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
@sandrask sandrask mentioned this issue Nov 15, 2020
Merged
sandrask added a commit to sandrask/sidetree-core-go that referenced this issue Nov 15, 2020
@sandrask
chore: remove references to kid MUST be present in protected headers
8c86f6f 
Spec has been updated to "kid MAY be present in the protected headers". Remove commented out code.

Closes trustbloc#365

Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sandrask sandrask

Labels
chore
Projects
None yet
Milestone
0.1.5
Development

Successfully merging a pull request may close this issue.

chore: remove references to kid MUST be present in protected headers sandrask/sidetree-core-go
2 participants
@troyronda @sandrask