Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submitting the same "create" request may result in a different DID suffix #699

Closed
bstasyszyn opened this issue Jun 9, 2023 · 0 comments · Fixed by #700
Closed

Submitting the same "create" request may result in a different DID suffix #699

bstasyszyn opened this issue Jun 9, 2023 · 0 comments · Fixed by #700
Assignees
@bstasyszyn
Labels
bug Something isn't working

Comments

@bstasyszyn
Copy link
Contributor

When calling NewCreateRequest multiple times with the "OpaqueDocument" field set to the same value each time, the "patches' array is built in random order and the delta hash (which is used to generate the DID suffix) can be different, resulting in a different DID suffix. The DID suffix should always be the same when submitting the same "create" operation.
@bstasyszyn bstasyszyn added the bug Something isn't working label Jun 9, 2023
@bstasyszyn bstasyszyn self-assigned this Jun 9, 2023
bstasyszyn added a commit to bstasyszyn/sidetree-core-go that referenced this issue Jun 9, 2023
@bstasyszyn
fix: Ensure "patches" slice is alway constructed in the same order
35b272e 
closes trustbloc#699

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@bstasyszyn bstasyszyn mentioned this issue Jun 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bstasyszyn bstasyszyn

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Ensure "patches" slice is alway constructed in the same order bstasyszyn/sidetree-core-go
1 participant
@bstasyszyn