fix: Fix race condition in resolve #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a race condition which may occur when published operations are first retrieved, not found, and then unpublished operations are deleted before they are retrieved. In this case the DID resolve results in a 404 "not found" error. This commit reverses the order of retrieval, i.e. first retrieve the unpublished operations and then the published ones. closes trustbloc#642 Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
Codecov Report
@@ Coverage Diff @@
## main #643 +/- ##
=======================================
Coverage 93.63% 93.63%
=======================================
Files 75 75
Lines 4102 4102
=======================================
Hits 3841 3841
Misses 146 146
Partials 115 115
Continue to review full report at Codecov.
|
fqutishat
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a race condition which may occur when published operations are first retrieved, not found, and then unpublished operations are deleted before they are retrieved. In this case the DID resolve results in a 404 "not found" error.
This commit reverses the order of retrieval, i.e. first retrieve the unpublished operations and then the published ones.
closes #642
Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com