Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Return the number of operations processed #644

Merged
merged 1 commit into from
Feb 4, 2022

Conversation

bstasyszyn
Copy link
Contributor

@bstasyszyn bstasyszyn commented Feb 4, 2022

Change the transaction processor interface to return the number of operations that were actually processed. In the case of duplicate operations, the number processed may be zero and the caller may wish to take a different path in this case.

Signed-off-by: Bob Stasyszyn Bob.Stasyszyn@securekey.com

Change the transaction processor interface to return the number of operations that were actually processed. In the case of duplicate operations, this number processed may be zero and the caller may wish to take a different path in this case.

Signed-off-by: Bob Stasyszyn <Bob.Stasyszyn@securekey.com>
@cla-bot cla-bot bot added the cla-signed label Feb 4, 2022
@codecov
Copy link

codecov bot commented Feb 4, 2022

Codecov Report

Merging #644 (d3d8fa8) into main (9cef7f4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #644   +/-   ##
=======================================
  Coverage   93.63%   93.63%           
=======================================
  Files          75       75           
  Lines        4102     4102           
=======================================
  Hits         3841     3841           
  Misses        146      146           
  Partials      115      115           
Impacted Files Coverage Δ
pkg/observer/observer.go 91.17% <100.00%> (ø)
pkg/versions/1_0/txnprocessor/txnprocessor.go 98.11% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cef7f4...d3d8fa8. Read the comment docs.

@bstasyszyn bstasyszyn merged commit a3c5de5 into trustbloc:main Feb 4, 2022
@bstasyszyn bstasyszyn deleted the numopsprocessed branch February 4, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants