Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Should not be able to specify both versionId and versionTime #652

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

sandrask
Copy link
Contributor

@sandrask sandrask commented Mar 2, 2022

Return an error if the client specifies both versionId and versionTime.

closes #651

Signed-off-by: Sandra Vrtikapa sandra.vrtikapa@securekey.com

@cla-bot cla-bot bot added the cla-signed label Mar 2, 2022
Return an error if the client specifies both versionId and versionTime.

closes trustbloc#651

Signed-off-by: Sandra Vrtikapa <sandra.vrtikapa@securekey.com>
@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #652 (5f3d1e8) into main (0166f20) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #652   +/-   ##
=======================================
  Coverage   93.65%   93.66%           
=======================================
  Files          76       76           
  Lines        4179     4184    +5     
=======================================
+ Hits         3914     3919    +5     
  Misses        148      148           
  Partials      117      117           
Impacted Files Coverage Δ
pkg/restapi/dochandler/resolvehandler.go 95.45% <100.00%> (+0.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0166f20...5f3d1e8. Read the comment docs.

@fqutishat fqutishat merged commit 43c05c8 into trustbloc:main Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should not be able to specify both versionId and versionTime
3 participants